Embedded GlassFish Review

Document: 3.1EmbeddedOnePager

Reviewer: Arun Gupta

Review date: May 20

Response date:

Item Type Comment Response
2.1 Clarification "any user provided JVM" - do we have any dependency on Sun JDK ? Will we test on other JDKs as well ? Whatever is supported by regular glassfish. No additional conditions are expected to be imposed by embedded and no additional testing is planned.
4.1.1 Clarification The target audience of each JAR should be clearly specified. Update spec.
4.1.1 Clarification Application+Runtime bundle will also be deployable via Maven, right ? yes, updated spec
4.1.3 Clarification IMHO, the default value of autoDelete should be true. This will keep the filesystem clean and user can still change it if its required. Updated spec. autoDelete will default to true if a temporary file system was used. Otherwise it would be ignored and the behavior would be as if the value was false.
4.14 Clarification v2 or v3 tests ? Whichever applicable - corrected the language in the spec.