GlassFish v2 CLI Review
| ID |
Location in the spec (use links if possible) |
Comments/Discussion |
Resolved – (YES/NO) |
| 1 |
JBI Commands |
The command names include the string jbi. This is generally a bad idea because the names can change. (No one thought that J2EE will change to JavaEE). I would recommend using functional command names. For example, I would recommend replacing deploy-jbi-service-assembly by deploy-service-assembly Mark Saunders: Removing "jbi" from the JBI command names could cause some of the specific jbi commands to become misleading. There are current commands that persist in asadmin, example, list-components, which will list all the deployed Java EE components. If we were to remove the jbi from our life cycle commands start-jbi-component, stop-jbi-component, shut-down-jbi-component ... They would become start-component, stop-component, shut-down-component ... These commands would be confusing to the user, since they only perform actions on jbi components. The problem is the overloaded word "component", by adding "jbi" to the command names, the user can distinguish between what component the command is referring too. |
|
|
| 2 |
JBI Commands |
The short options for interactive, host etc. are uppercase "I" and "H" respectively. This may be inconsistent as compared to other asadmin commands. Mark Saunders: The JBI development did not add these short options to the XML descriptor file. The JBI commands are using these options, but did not change to long or short values. Since they were not changed, they should be consistent with the existing asadmin commands. |
|
|
|
