| This page provides links to review drafts of new and changed documentation for the Enterprise JavaBeans project as listed in the Enterprise JavaBeans Documentation Plan. Mandatory reviewers for each item are listed in each section. The deadline for review comments is Monday, February 7th. Please provide your feedback by adding comments to this page. Please review existing comments before posting to avoid duplicates. Changes to existing documentation since the last release are marked with change bars. No changes are marked in new documentation. Please provide your feedback by adding a comment to this page. To simplify the processing of your comments, please add your comments in the format in the sample comment. Review existing comments to see known issues and avoid duplicates.
Mandatory reviewers in addition to the reviewers that are listed in the table are as follows:
| Comment ID |
Location |
Comment |
| RJP-001 |
list-timers(1) man page |
Sample comment. Should provide a proposed fix and correct content if applicable. |
| RJP-002 |
migrate-timers(1) man page |
Another sample comment. |
 Posted by rebeccaparks at Nov 08, 2010 12:48
|
| CF-001 |
list-timers(1) man page |
At the bottom See Also section, it refers to old version of dev guide. Need to point to the current version?
|
| CF-002 |
migrate-timers(1) man page |
looks good.
|
CF-003
|
Migrating EJB Timers
|
Need to remove any reference to standalone instance. migrate-timers only supports migration between instances within the same cluster. Also need to modify the example to clustered instances as source and target.
|
CF-004
|
ADG 16 Using the Java Naming and Directory Interface |
p248 Global JNDI Names, #3: add @javax.ejb.Singleton after @javax.ejb.Stateless
|
CF-005
|
ADG 16 Using the Java Naming and Directory Interface |
p252 PrimitivesAndStringFactory, #2:
remove integer;
remove character.
|
CF-005
|
ADG 16 Using the Java Naming and Directory Interface |
p255 Mapping References, in the paragraph starting with "These elements are part of the...", change glassfish-ejb-ref.xml to glassfish-ejb-jar.xml, and add glassfish-application.xml after glassfish-ejb-jar.xml
|
CF-006
|
ADG 16 Using the Java Naming and Directory Interface |
p255 Mapping References, in the paragraph starting with "This references a resource with the JNDI name of java:comp/env/jdbc/helloDbDs", change the JNDI name from java:comp/env/jdbc/helloDbDs to jdbc/helloDbDs |
CF-007
|
C Elements of Deployment Descriptors |
looks good.
|
| CF-008 |
Sign off review
|
Still need to resolve CF-003
|
CF-009
|
Sign off review
|
The fix for CF-006 is incorrect. Need to change "java:jdbc/helloDbDs" to "jdbc/helloDbDs" |
Posted by cheng.fang at Nov 10, 2010 08:21
|
| Comment ID |
Location |
Comment |
| trm-1 |
migrate-timers(1) man page |
In the example, "server" is probably not a good example server name to use since one would probably not migrate EJB timers from the DAS to another stand-alone instance. |
| trm-2 |
migrate-timers |
In the operands section, what does "should not be active" mean here? How does one make a server not active? Presumably this does not mean stopped. Is there a "make not active" command? Or does this mean that the load balancer has been modified to not directly traffic to the instance? |
| trm-3 |
migrate-timers |
In the description, the phrase "when a server instance stops or fails abnormally" is confusing to me. I was under the impression that the migrate-timers command is used when wants to gracefully bring down a server and that the timers are actually migrated when the command runs. Thus, the migration happens before a server is stopped, not "when". But this makes it sound like what this command does it to just configure the system so that timers will be migrated later, when the server stops or fails. Which is it? Also, does a server ever fail normally? If not, the word abnormally can be omitted. |
Posted by trmueller at Nov 17, 2010 11:58
|
| Comment ID |
Location |
Comment |
| mv-1 |
EJB Timer Service |
Remove: "Ideally, each cluster should have its own timer table." - we can't support that |
| mv-2 |
EJB Timer Service |
"Maximum Redeliveries ...due for exception or rollback." - after an exception or a rollback of a container-managed transaction. |
| mv-3 |
EJB Timer Service |
Need to describe how to set EJB Timer Service resource without changing jdbc/__TimerPool setup |
| mv-4 |
EJB Timer Service |
Need to describe how to set EJB Timer Service pool for a cluster |
| mv-5 |
EJB Timer Service |
https://github.com/javaee/glassfish/issues/12878 is not addressed |
| mv-6 |
EJB Module Deployment Guidelines |
"Some changes to an application between redeployments prevent this feature from working
properly."=> a) Should be "Some changes to an application between redeployments can prevent...". b) another example would be changes to the EJB names or adding or removing EJBs to/from an application. |
| mv-7-1 |
EJB Timer Service |
Need to add examples of asadmin command to "You can change the following EJB Timer Service settings" |
| mv-7-2 |
EJB Timer Service |
"The EJB Timer Service in GlassFish Server is preconfgured to use an embedded version of the Java DB database." => add that because of this, the configuration needs to be changed when EJB Timer Service is used in a cluster. |
| mv-7-3 |
EJB Timer Service |
"To preserve active timer data, GlassFish Server serializes the data and saves it in memory. To restore the data, the class loader of the newly redeployed application deserializes the data that was previously saved." => This is incorrect. Persistent timers are stored in the database. When application is undeployed, normally all the corresponding timers are deleted from the database. But if it is redeployed with --keepstate option, persistent timers are not deleted, and are restarted after the new version of the application is loaded into the EJB container. |
| mv-7-4a |
EJB Timer Service |
"to deploy the default jdbc/__default timer that is confgured by default in GlassFish Server 3.1." => This is incorrect. As you know, jdbc/__default is not a timer. "to use JDBC resource with the JNDI name "jdbc/__default", available with GlassFish Server 3.1 installation,..." |
| mv-7-4b |
EJB Timer Service |
"In most production environments, it is recommended that you create your own timer rather than using this default timer." => "In most production environments, it is recommended that you create your own timer resource rather than using this default resource." |
| mv-7-4c |
EJB Timer Service |
Steps to enable jdbc/__default in a cluster should be listed in the corresponding (admin?) guide |
| mv-7-4d |
EJB Timer Service |
asadmin command example on how to point EJB Timer Service to a JDBC resource is the only step needed |
| mv-8-1 |
EJB Module Deployment Guidelines |
Typo: "Some changes to an application between redeployments can ent this feature from working properly." |
Posted by -marina at Feb 04, 2011 13:00
|
|
list-timers.1.pdf (application/pdf)
